<html><body>
<p><font size="2" face="sans-serif">I didn't. My patch only covers PPC64 building on your CNK/BGQ one.</font><br>
<br>
<font size="2" face="sans-serif">I have no strong opinion about this - if it works having it look like linux then it's all right by me.</font><br>
<br>
<br>
<font size="2" face="sans-serif">Thanks</font><br>
<br>
<font size="2" face="sans-serif">-- Carlo</font><br>
<br>
<br>
<br>
<img width="16" height="16" src="cid:1__=0ABBF7BDDFDE19888f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for Hal Finkel ---08/08/2014 10:07:24 AM-------- Original Message ----- > From: "Carlo Bertolli" <cbertol"><font size="2" color="#424282" face="sans-serif">Hal Finkel ---08/08/2014 10:07:24 AM-------- Original Message ----- > From: "Carlo Bertolli" <cbertol@us.ibm.com></font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Hal Finkel <hfinkel@anl.gov></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">Carlo Bertolli/Watson/IBM@IBMUS</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Cc: </font><font size="1" face="sans-serif"><openmp-dev@dcs-maillist2.engr.illinois.edu>, James H Cownie <james.h.cownie@intel.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">08/08/2014 10:07 AM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [Openmp-dev] OS definitions</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<tt><font size="2">----- Original Message -----<br>
> From: "Carlo Bertolli" <cbertol@us.ibm.com><br>
> To: "James H Cownie" <james.h.cownie@intel.com><br>
> Cc: openmp-dev@dcs-maillist2.engr.illinois.edu<br>
> Sent: Friday, August 8, 2014 8:47:36 AM<br>
> Subject: Re: [Openmp-dev] OS definitions<br>
> <br>
> <br>
> <br>
> <br>
> Hi Jim,<br>
> <br>
> Yes you are right - it should be included. I forgot to add it.<br>
<br>
Did you test that? As I recall, CNK pretends to be Linux, so KMP_OS_LINUX is already defined on CNK.<br>
<br>
-Hal<br>
<br>
> <br>
> <br>
> Thanks<br>
> <br>
> -- Carlo<br>
> <br>
> <br>
> Inactive hide details for "Cownie, James H" ---08/08/2014 08:03:19<br>
> AM---Carlo, I'm integrating the BGQ stuff into the code we'r"Cownie,<br>
> James H" ---08/08/2014 08:03:19 AM---Carlo, I'm integrating the BGQ<br>
> stuff into the code we're getting ready to push, and I have a<br>
> questio<br>
> <br>
> From: "Cownie, James H" <james.h.cownie@intel.com><br>
> To: "openmp-dev@dcs-maillist2.engr.illinois.edu"<br>
> <openmp-dev@dcs-maillist2.engr.illinois.edu><br>
> Cc: Carlo Bertolli/Watson/IBM@IBMUS<br>
> Date: 08/08/2014 08:03 AM<br>
> Subject: OS definitions<br>
> <br>
> <br>
> <br>
> <br>
> Carlo,<br>
> <br>
> I’m integrating the BGQ stuff into the code we’re getting ready to<br>
> push, and I have a question…<br>
> In kmp_os.h there’s this code<br>
> <br>
> <br>
> /* ---------------------- Operating system recognition<br>
> ------------------- */<br>
> <br>
> #define KMP_OS_LINUX 0<br>
> #define KMP_OS_FREEBSD 0<br>
> #define KMP_OS_DARWIN 0<br>
> #define KMP_OS_FREEBSD 0<br>
> #define KMP_OS_WINDOWS 0<br>
> #define KMP_OS_CNK 0<br>
> #define KMP_OS_UNIX 0 /* disjunction of KMP_OS_LINUX, KMP_OS_DARWIN<br>
> etc. */<br>
> <br>
> #define KMP_ARCH_X86 0<br>
> #define KMP_ARCH_X86_64 0<br>
> #define KMP_ARCH_PPC64 0<br>
> <br>
> #ifdef _WIN32<br>
> # undef KMP_OS_WINDOWS<br>
> # define KMP_OS_WINDOWS 1<br>
> #endif<br>
> <br>
> #if ( defined __APPLE__ && defined __MACH__ )<br>
> # undef KMP_OS_DARWIN<br>
> # define KMP_OS_DARWIN 1<br>
> #endif<br>
> <br>
> // in some ppc64 linux installations, only the second condition is<br>
> met<br>
> #if ( defined __linux )<br>
> # undef KMP_OS_LINUX<br>
> # define KMP_OS_LINUX 1<br>
> #elif ( defined __linux__)<br>
> # undef KMP_OS_LINUX<br>
> # define KMP_OS_LINUX 1<br>
> #else<br>
> #endif<br>
> <br>
> #if ( defined __FreeBSD__ )<br>
> # undef KMP_OS_FREEBSD<br>
> # define KMP_OS_FREEBSD 1<br>
> #endif<br>
> <br>
> #if ( defined __bgq__ )<br>
> # undef KMP_OS_CNK<br>
> # define KMP_OS_CNK 1<br>
> #endif<br>
> <br>
> #if (1 != KMP_OS_LINUX + KMP_OS_FREEBSD + KMP_OS_DARWIN +<br>
> KMP_OS_WINDOWS)<br>
> # error Unknown OS<br>
> #endif<br>
> <br>
> Shouldn’t that last test also include KMP_OS_CNK? Or does CNK pretend<br>
> to be one of the other OSes as well?<br>
> <br>
> -- Jim<br>
> <br>
> James Cownie <james.h.cownie@intel.com><br>
> SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)<br>
> Tel: +44 117 9071438<br>
> <br>
> <br>
> ---------------------------------------------------------------------<br>
> Intel Corporation (UK) Limited<br>
> Registered No. 1134945 (England)<br>
> Registered Office: Pipers Way, Swindon SN3 1RJ<br>
> VAT No: 860 2173 47<br>
> <br>
> This e-mail and any attachments may contain confidential material for<br>
> the sole use of the intended recipient(s). Any review or distribution<br>
> by others is strictly prohibited. If you are not the intended<br>
> recipient, please contact the sender and delete all copies.<br>
> <br>
> <br>
> _______________________________________________<br>
> Openmp-dev mailing list<br>
> Openmp-dev@dcs-maillist2.engr.illinois.edu<br>
> </font></tt><tt><font size="2"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev">http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev</a></font></tt><tt><font size="2"><br>
> <br>
<br>
-- <br>
Hal Finkel<br>
Assistant Computational Scientist<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
</font></tt><br>
</body></html>