[Openmp-dev] coding style

[Joachim Protze via Openmp-dev]

Am 18.06.20 um 13:47 schrieb Jon Chesterfield via Openmp-dev:
>      
>          *   Shilei asked what coding style should be used for openmp
>     libraries.  Currently it is inconsistent an example is device_id
>          *   Suggestion is to use llvm style coding for new code as it
>     would involve lot of work to retroactively fix all the code.
>          *   The rewrite of the device rtl should already be following
>     llvm style.
> 
> 
> I'd like us to run clang-format with the llvm config across all of
> libomptarget. Failing that, at least over all of deviceRTL.
> 
> Any objections? Any time spent on whitespace in reviews is time badly spent.
> 
> There's also the current_naming_system vs int V difference. If anyone
> knows a tool that will convert between the two reliably I'd like us to
> run that too. We may have API stability conflicts there though.
> 

Harbormaster suggests using clang-tidy. (And marks failures in all
reviews as, when different style is used.)

A quick test with the runtime src shows, that clang-tidy does not modify
the variables when uses in defines like KE_TRACE, which are used all
over the runtime code. I could not find a flag to change this behavior.

- Joachim

> Cheers
> 
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev
>