[Openmp-dev] Two patches

[Hal Finkel]

----- Original Message -----
> From: cbergstrom at pathscale.com
> To: "Terry L Wilmarth" <terry.l.wilmarth at intel.com>, "Terry L Wilmarth" <terry.l.wilmarth at intel.com>,
> openmp-dev at dcs-maillist2.engr.illinois.edu
> Sent: Tuesday, March 31, 2015 11:26:43 AM
> Subject: Re: [Openmp-dev] Two patches
> 
> 
> 
> I'd like a chance to review. Please wait. I thought Hal or someone
> would chime in
> 
> 

I'll look at them now...

 -Hal

> 
> 
> From: Wilmarth, Terry L
> Sent: Tuesday, March 31, 2015 23:23
> To: Wilmarth, Terry L; openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: Re: [Openmp-dev] Two patches
> 
> 
> 
> 
> 
> Andrey,
> 
> Please check in these patches.
> 
> Thanks!
> 
> 
> 
> 
> 
> 
> 
> From: openmp-dev-bounces at cs.uiuc.edu
> [mailto:openmp-dev-bounces at cs.uiuc.edu] On Behalf Of Wilmarth, Terry
> L
> Sent: Monday, March 30, 2015 11:17 AM
> To: openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: Re: [Openmp-dev] Two patches
> 
> 
> 
> Just a reminder, this is awaiting review. Thanks!
> 
> 
> 
> 
> 
> From: openmp-dev-bounces at cs.uiuc.edu [
> mailto:openmp-dev-bounces at cs.uiuc.edu ] On Behalf Of Wilmarth, Terry
> L
> Sent: Thursday, March 26, 2015 12:33 PM
> To: openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: [Openmp-dev] Two patches
> 
> 
> 
> Hello,
> 
> 
> 
> Here are 2 more patches:
> 
> 
> 
> 1. hier1.patch: This short patch eliminates writing to the depth
> field of the machine_hierarchy data structure. The write was
> unnecessary, as the depth can simply be pulled out of the data
> structure to a local variable, and then modified as needed. This
> also allowed the removal of the base_depth field, because now the
> depth field is the base depth, and does not need to be modified.
> 
> 2. safe_api.patch: This patch is large, but very simple. This change
> replaces banned C API calls with safe calls to meet the SDL
> guidelines. Most calls have their safe alternatives on Windows, but
> we just define macros for other platforms.
> 
> a. kmp_safe_c_api.h defines macros that replace the banned calls
> 
> b. APIs for non-windows platforms will be filled in later
> 
> 
> 
> Thanks!
> 
> Terry
> 
> 
> 
> --
> Terry L. Wilmarth
> terry.l.wilmarth at intel.com 217/403-4251
> Intel/SSG/DPD/TCAR/RAD/Threading Runtimes
> 
> 
> 
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at dcs-maillist2.engr.illinois.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory