[Openmp-dev] Three small patches

[Hal Finkel]

----- Original Message -----
> From: "Terry L Wilmarth" <terry.l.wilmarth at intel.com>
> To: openmp-dev at dcs-maillist2.engr.illinois.edu
> Sent: Tuesday, March 3, 2015 11:16:49 AM
> Subject: [Openmp-dev] Three small patches
> 
> 
> Hello,
> 
> Here are three very small patches:
> 
> 1) build_fixes.patch: removes -fstack-protector flags from oss/llvm
> builds; fixes an oversight in AsmFlags for builds using icc on
> Windows; adds KMP_NESTED_HOT_TEAMS definition.

"adds KMP_NESTED_HOT_TEAMS definition." -- this part LGTM, please commit it separately.

"removes -fstack-protector flags from oss/llvm builds" -- but the patch does not appear to do this. It looks like it is moving from MS build flag definitions around (and I'm less fond of the new formatting).

> 
> 2) affinity_comment.patch: comment for affinity balanced improved as
> suggested in LLVM review.

LGTM (you don't need pre-commit review for comment improvements).

> 
> 3) placement.patch: corrected dn_successors placement

And also adds dn_routine? What was incorrect about the previous definition?

 -Hal

> 
> 
> 
> Apologies for not using whatever mechanisms are in place for
> submitting patches for review. Johnny is on leave, and I know he was
> working on a better way to get our changes out, so please bear with
> me as I try to keep us from getting too far behind on these.
> 
> 
> 
> Thanks!
> 
> Terry
> 
> --
> Terry L. Wilmarth
> terry.l.wilmarth at intel.com 217/403-4251
> Intel/SSG/DPD/TCAR/RAD/Threading Runtimes
> 
> 
> _______________________________________________
> Openmp-dev mailing list
> Openmp-dev at dcs-maillist2.engr.illinois.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory