[Openmp-dev] residual instances of iomp

[Peyton, Jonathan L]

Nope, those files have been rendered unused.

-- Johnny

-----Original Message-----
From: Jack Howarth [mailto:howarth.mailing.lists at gmail.com] 
Sent: Monday, June 1, 2015 1:00 PM
To: Peyton, Jonathan L
Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: residual instances of iomp

Jonathan,
     What about the files...

runtime/src/include/30/iomp.h.var
runtime/src/include/30/iomp_lib.h.var
runtime/src/include/40/iomp.h.var
runtime/src/include/40/iomp_lib.h.var
runtime/src/include/41/iomp.h.var
runtime/src/include/41/iomp_lib.h.var
runtime/src/libiomp.rc.var

Do we still need those?
        Jack

On Mon, Jun 1, 2015 at 1:09 PM, Peyton, Jonathan L <jonathan.l.peyton at intel.com> wrote:
> I'm holding off on the offload/ changes because I believe they are going to commit things soon, including changes to the Makefile.  Plus, the offload subdirectory doesn't affect the LLVM autobuild.
>
> The iomp references in runtime/src/rules.mk are something I added which creates the symlinks in the exports directory, similar to the symlinks created at install time for CMake.
>
>>Also, shouldn't the instance's of "Intel(R)" be changed to "LLVM" for the library description...
> I'm not doing anything in the offload/ subdirectory for the same reasons as above.  I wasn't going to change anything in libiomp.rc.var because it is going to be deleted soon.
> I can change the libomp.rc.var cases.
>
> -- Johnny
>
> -----Original Message-----
> From: Jack Howarth [mailto:howarth.mailing.lists at gmail.com]
> Sent: Monday, June 1, 2015 5:45 AM
> To: Peyton, Jonathan L; openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: Re: residual instances of iomp
>
> Jonathan,
>        The instances of "iomp" still remain in the offload subdirectory....
>
> offload/Makefile:# libiomp_host_dir - path to host libiomp directory 
> (unnecessary if compiler_host is icc) offload/Makefile:# 
> libiomp_target_dir - path to target libiomp directory (unnecesarry if 
> compiler_target is icc) offload/Makefile:opts_liboffload=-shared 
> -Wl,-soname,liboffload.so.5 -ldl -lstdc++ -liomp5 
> offload/Makefile:ifneq ($(libiomp_host_dir), )
> offload/Makefile:  opts_liboffload_host+=-L$(libiomp_host_dir)
> offload/Makefile:ifneq ($(libiomp_target_dir), )
> offload/Makefile:  opts_liboffload_target+=-L$(libiomp_target_dir)
> offload/Makefile: @echo "libiomp_host_dir = $(libiomp_host_dir)"
> offload/Makefile: @echo "libiomp_target_dir = $(libiomp_target_dir)"
> offload/README.txt:libiomp_host_dir:     The path to the host Intel(R)
> OpenMP* Runtime Library.
> offload/README.txt:libiomp_target_dir:   The path to the target
> Intel(R) OpenMP* Runtime
>
> as well as in...
>
> runtime/src/rules.mk: cd $(out_lib_dir) ; $(cp) $(lib_file)
> libiomp5md$(dll) ; $(cp) $(imp_file) libiomp5md$(lib)
> runtime/src/rules.mk: cd $(out_lib_dir) ; ln -sf $(lib_file) 
> libiomp5$(dll)
>
> Also, shouldn't the instance's of "Intel(R)" be changed to "LLVM" for the library description...
>
> offload/doc/doxygen/config:PROJECT_NAME           =
> "Intel® Offload Runtime Library"
> offload/doc/doxygen/header.tex:{\Large
> Intel\textsuperscript{\textregistered} Offload Runtime Library }\\
> offload/README.txt:       README for Intel(R) Offload Runtime Library
> offload/README.txt:Intel(R) Offload Runtime Library requires additional software:
> offload/README.txt:1) Intel(R) OpenMP* Runtime Library.  You can 
> either download the source
> offload/README.txt:2) Intel(R) COI Runtime Library and Intel(R) MYO Runtime Library.  These offload/README.txt:How to Build the Intel(R) Offload Runtime Library offload/README.txt:build the Intel(R) Offload Runtime Library.  To see the default settings,
> offload/README.txt:libiomp_host_dir:     The path to the host Intel(R)
> OpenMP* Runtime Library.
> runtime/Build_With_CMake.txt: [ Intel(R) Many Integrated Core Library
> (Intel(R) MIC Library) ]
> runtime/src/libiomp.rc.var:                VALUE "FileDescription",
> "Intel(R) OpenMP* Runtime Library${{ our $MESSAGE_CATALOG; $MESSAGE_CATALOG ? " Message Catalog" : "" }}\0"
> runtime/src/libiomp.rc.var:                VALUE "ProductName",
> "Intel(R) OpenMP* Runtime Library\0"
> runtime/src/libiomp.rc.var:                    "Intel(R) OpenMP* ${{
> our ( $MESSAGE_CATALOG, $KMP_TYPE ); $MESSAGE_CATALOG ? "Runtime Library Message Catalog" : "$KMP_TYPE Library" }} "
> runtime/src/libomp.rc.var:                VALUE "FileDescription",
> "Intel(R) OpenMP* Runtime Library${{ our $MESSAGE_CATALOG; $MESSAGE_CATALOG ? " Message Catalog" : "" }}\0"
> runtime/src/libomp.rc.var:                VALUE "ProductName",
> "Intel(R) OpenMP* Runtime Library\0"
> runtime/src/libomp.rc.var:                    "Intel(R) OpenMP* ${{
> our ( $MESSAGE_CATALOG, $KMP_TYPE ); $MESSAGE_CATALOG ? "Runtime Library Message Catalog" : "$KMP_TYPE Library" }} "
>
>              Jack