[Openmp-dev] Getting Architecture Patch

[Churbanov, Andrey]

Committed, revision 226479.

The Carlo's and Johnny's patches differ only in order of lines (or elsif cases), or in comments. I have committed Johnny's patch.

Thanks,
Andrey

From: Peyton, Jonathan L
Sent: Monday, January 19, 2015 8:42 PM
To: Carlo Bertolli; Churbanov, Andrey
Cc: C Bergström; Cownie, James H; openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: RE: Getting Architecture Patch

Carlo,

Thank you for raising those issues.

I believe I have fixed those two problems with this updated version of this patch.   I could actually test the makefile logic by forcing a compile to ppc64le and seeing that it was attempting to put it in lin_ppc64le and also CACHE_LINE is 128 again for both ppc64 and ppc64le.

Andrey,

can you commit this?

To apply patch:
$ patch –p0 < ppc64le-support-v3.patch

-- Johnny

From: Carlo Bertolli [mailto:cbertol at us.ibm.com]
Sent: Friday, January 16, 2015 6:33 PM
To: Peyton, Jonathan L
Cc: C Bergström; Cownie, James H; openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>
Subject: RE: Getting Architecture Patch


Hi Jonathan

Thanks for the changes (not sure why they did not show up in the conflict list after git merge).
This works for me on both ppc64 and ppc64le.

I noticed some minor changes to be done for ppc64le when using make:

1. CACHE_LINE changes during compilation, from 128 (correct) to 64 (incorrect).

2. The target directory is ppc64 instead of ppc64le.

For now I can live with both, if this is fine by you. I will submit a patch for this later.


Thanks again

-- Carlo


[Inactive hide details for "Peyton, Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most]"Peyton, Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most recent changes (Intel® MIC changes), and also ad

From: "Peyton, Jonathan L" <jonathan.l.peyton at intel.com<mailto:jonathan.l.peyton at intel.com>>
To: Carlo Bertolli/Watson/IBM at IBMUS, C Bergström <cbergstrom at pathscale.com<mailto:cbergstrom at pathscale.com>>
Cc: "Cownie, James H" <james.h.cownie at intel.com<mailto:james.h.cownie at intel.com>>, "openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>" <openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>>
Date: 01/16/2015 07:01 PM
Subject: RE: Getting Architecture Patch

________________________________



Carlo,

I have applied your patch on top of the most recent changes (Intel® MIC changes), and also added a few changes:

diff --git a/runtime/CMakeLists.txt b/runtime/CMakeLists.txt
Got rid of this deletion of AARCH64
set(INTEL64 FALSE)
set(ARM FALSE)
-set(AARCH64 FALSE)
+set(PPC64BE FALSE)
+set(PPC64LE FALSE)

diff --git a/runtime/src/kmp_os.h b/runtime/src/kmp_os.h
Got rid of this deletion of AARCH64
-#define KMP_ARCH_PPC64      0
-#define KMP_ARCH_AARCH64    0
+#define KMP_ARCH_X86_64     0

In makefile.mk, I added a few places where I feel it should be checking for both ppc64 and ppc64le, you can see this in the attached patch file.

Check this out and see if it is correct.
To apply the patch on clean updated repository:
$ patch –p0 < ppc64le-support-v2.patch

-- Johnny

From: Carlo Bertolli [mailto:cbertol at us.ibm.com]
Sent: Thursday, January 15, 2015 11:00 PM
To: C Bergström
Cc: Cownie, James H; Peyton, Jonathan L; openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>
Subject: Re: Getting Architecture Patch


Hi

Did now see that one - I removed it in the attached version. Let me know if I broke something.


(See attached file: ppc64le-support.patch)

Thanks

-- Carlo

[Inactive hide details for C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP]C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP_ARCH_X86_64     0

From: C Bergström <cbergstrom at pathscale.com<mailto:cbergstrom at pathscale.com>>
To: Carlo Bertolli/Watson/IBM at IBMUS
Cc: "Peyton, Jonathan L" <jonathan.l.peyton at intel.com<mailto:jonathan.l.peyton at intel.com>>, "Cownie, James H" <james.h.cownie at intel.com<mailto:james.h.cownie at intel.com>>, "openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>" <openmp-dev at dcs-maillist2.engr.illinois.edu<mailto:openmp-dev at dcs-maillist2.engr.illinois.edu>>
Date: 01/15/2015 11:53 PM
Subject: Re: Getting Architecture Patch

________________________________




A whitespace change snuck in at here (extra tab)

+#define KMP_ARCH_X86_64     0

Otherwise the patch is probably in align with the intention[attachment "ppc64le-support-v2.patch" deleted by Carlo Bertolli/Watson/IBM]

--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150119/536ef908/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 105 bytes
Desc: image001.gif
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20150119/536ef908/attachment.gif>