[Openmp-dev] Three patches

Churbanov, Andrey Andrey.Churbanov at intel.com
Thu Feb 26 01:08:49 PST 2015


Right, internally we still use build.pl and do not use cmake for our builds (maybe just habit? But it is hard to get rid of convenient working tools...).

Regards,
Andrey

> -----Original Message-----
> From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-
> bounces at cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
> Sent: Thursday, February 26, 2015 10:25 AM
> To: Peyton, Jonathan L
> Cc: openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: Re: [Openmp-dev] Three patches
> 
> Thanks as well!
> 
> As you committed my patches for build.pl, I suppose it is still needed and used?
> 
> Jonas
> 
> > -----Original Message-----
> > From: Peyton, Jonathan L [mailto:jonathan.l.peyton at intel.com]
> > Sent: Wednesday, February 25, 2015 8:06 PM
> > To: Hahnfeld, Jonas
> > Subject: RE: Three patches
> >
> > We have committed your patches.
> >
> > Thanks again!
> >
> > -- Johnny
> >
> > -----Original Message-----
> > From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-
> > bounces at cs.uiuc.edu] On Behalf Of Peyton, Jonathan L
> > Sent: Wednesday, February 18, 2015 12:37 PM
> > To: Hahnfeld, Jonas; openmp-dev at dcs-maillist2.engr.illinois.edu
> > Subject: Re: [Openmp-dev] Three patches
> >
> > These patches look good to me.  Thanks for the fixes and sorry for the
> > silence.
> >
> > We will integrate these very soon.
> >
> > -- Johnny
> >
> > -----Original Message-----
> > From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-
> > bounces at cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
> > Sent: Wednesday, February 18, 2015 1:14 AM
> > To: openmp-dev at dcs-maillist2.engr.illinois.edu
> > Subject: Re: [Openmp-dev] Three patches
> >
> > Any comments on this? Or shall I put those on Phabricator as well?
> >
> > Jonas
> >
> > > -----Original Message-----
> > > From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-
> > > bounces at cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
> > > Sent: Thursday, February 05, 2015 10:27 AM
> > > To: openmp-dev at dcs-maillist2.engr.illinois.edu
> > > Subject: [Openmp-dev] Three patches
> > >
> > > Hi!
> > >
> > > Find attached 3 patches. I hope that this is the correct way to
> > > submit them and that they are ok.
> > >
> > > The first patch removes all header files for OpenMP 2.5.
> > > The build will fail anyway since r219214 and an OpenMP-2.5 build was
> > > never possible with CMake.
> > >
> > > The second patch sets the Intel compiler as default when building
> > > for the MIC without CMake (as it is already mentioned in the
> documentation).
> > > It also fixes some tiny problems with the makefiles for the MIC.
> > >
> > > Finally the third patch exports the common header files to exports/
> > > with CMake.
> > >
> > > They should all apply independently and order shouldn't matter.
> > > As I locally use git and extracted them with git format-patch, the
> > > commands
> > > are:
> > > $ patch -p1 <
> > > 0001-Remove-reference-to-OpenMP-2.5-in-build.pl-and-delet.patch
> > > $ patch -p1 < 0002-Simplify-MIC-builds-without-CMake.patch
> > > $ patch -p1 < 0003-CMake-Export-common-header-files.patch
> > >
> > > As I fixed some issues with the old build.pl: Is this still used
> anymore?
> > > Or will it get deleted in the near future, switching completely to
> CMake?
> > >
> > > Cheers,
> > > Jonas
> > >
> > > --
> > > Jonas Hahnfeld, MATSE-Auszubildender
> > >
> > > IT Center
> > > Group: High Performance Computing
> > > Division: Computational Science and Engineering RWTH Aachen
> > > University Seffenter Weg 23 D 52074  Aachen (Germany)
> > > Hahnfeld at itc.rwth-
> > aachen.de
> > > www.itc.rwth-aachen.de
> >
> >
> > _______________________________________________
> > Openmp-dev mailing list
> > Openmp-dev at dcs-maillist2.engr.illinois.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/openmp-dev

--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the Openmp-dev mailing list