[Openmp-dev] Three patches

Peyton, Jonathan L jonathan.l.peyton at intel.com
Wed Feb 18 10:36:34 PST 2015


These patches look good to me.  Thanks for the fixes and sorry for the silence.

We will integrate these very soon.

-- Johnny

-----Original Message-----
From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev-bounces at cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
Sent: Wednesday, February 18, 2015 1:14 AM
To: openmp-dev at dcs-maillist2.engr.illinois.edu
Subject: Re: [Openmp-dev] Three patches

Any comments on this? Or shall I put those on Phabricator as well?

Jonas

> -----Original Message-----
> From: openmp-dev-bounces at cs.uiuc.edu [mailto:openmp-dev- 
> bounces at cs.uiuc.edu] On Behalf Of Hahnfeld, Jonas
> Sent: Thursday, February 05, 2015 10:27 AM
> To: openmp-dev at dcs-maillist2.engr.illinois.edu
> Subject: [Openmp-dev] Three patches
> 
> Hi!
> 
> Find attached 3 patches. I hope that this is the correct way to submit 
> them and that they are ok.
> 
> The first patch removes all header files for OpenMP 2.5.
> The build will fail anyway since r219214 and an OpenMP-2.5 build was 
> never possible with CMake.
> 
> The second patch sets the Intel compiler as default when building for 
> the MIC without CMake (as it is already mentioned in the documentation).
> It also fixes some tiny problems with the makefiles for the MIC.
> 
> Finally the third patch exports the common header files to exports/ 
> with CMake.
> 
> They should all apply independently and order shouldn't matter.
> As I locally use git and extracted them with git format-patch, the 
> commands
> are:
> $ patch -p1 <
> 0001-Remove-reference-to-OpenMP-2.5-in-build.pl-and-delet.patch
> $ patch -p1 < 0002-Simplify-MIC-builds-without-CMake.patch
> $ patch -p1 < 0003-CMake-Export-common-header-files.patch
> 
> As I fixed some issues with the old build.pl: Is this still used anymore?
> Or will it get deleted in the near future, switching completely to CMake?
> 
> Cheers,
> Jonas
> 
> --
> Jonas Hahnfeld, MATSE-Auszubildender
> 
> IT Center
> Group: High Performance Computing
> Division: Computational Science and Engineering RWTH Aachen University 
> Seffenter Weg 23 D 52074  Aachen (Germany) Hahnfeld at itc.rwth-aachen.de 
> www.itc.rwth-aachen.de





More information about the Openmp-dev mailing list