[Openmp-dev] Initial Intel Cmake Build System Patch

"C. Bergström" cbergstrom at pathscale.com
Mon Jun 9 15:32:57 PDT 2014


On 06/10/14 04:06 AM, Peyton, Jonathan L wrote:
> C. Bergström,
>
> It's fine if you want to change the flag-grabbing layout.  Although, I feel having icc.cmake, gcc.cmake, clang.cmake, common.cmake, etc. would be just as hard to maintain.  i.e., If some flag is only valid for a subset of compilers then all those *.cmake files will have to be modified.  Each file will also have its own if(OS_TYPE) sections.  If you really want to support every possible compiler, you are just going to have to strip away as many of the compiler-specific flags as you can.
Why is this being set at all? This is really all stuff the user can set 
and possibly should be moved to documentation if you don't like the idea 
of icc.cmake. I don't see how removing all the if () mess isn't a good idea.



More information about the Openmp-dev mailing list