[Openmp-dev] [PATCH] [Revisedx2] Initial cmake support

[Hal Finkel]

----- Original Message -----
> From: "Andrey Bokhanko" <andreybokhanko at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: openmp-dev at dcs-maillist2.engr.illinois.edu, "David Chisnall" <dc552 at cam.ac.uk>, "Alp Toker" <alp at nuanti.com>
> Sent: Monday, June 2, 2014 12:16:56 PM
> Subject: Re: [Openmp-dev] [PATCH] [Revisedx2] Initial cmake support
> 
> 
> Hal,
> 
> 
> 
> 
> 
> 
> To which message are you referring?
> 
> 
> 
> This one:
> http://lists.cs.uiuc.edu/pipermail/openmp-dev/2014-June/000146.html
> 
> 
> 
> To be fair, this is a bit different. First, as I've explained, you
> don't need approval from the code owner, you need approval from some
> established contributor who is knowledgeable in that part of the
> code, including design, implementation details and future direction
> (and, in effect, who is willing to take responsibility for your
> change). The problem you have with many of the OpenMP patches is
> that only the code owners are in such a position, but please don't
> over-generalize. There are many more qualified people for build
> system changes (although, FWIW, not as many as one might think).
> Please understand that, as far as we could tell, the future
> direction (CMake) was clear, and so Alp had all of the knowledge he
> needed to approve the commit.
> 
> 
> 
> Agree -- no two things are exactly the same.
> 
> 
> Said this, do you think reviewing and committing a new build system
> on a weekend, with no chance to have a review with project architect
> is a good and collaborative approach?

There are two issues here. First, a specific request was made to await Jim's review (and, so, we should have waited). Had that not been the case, it is questionable. Alp is familiar with LLVM's build systems, and given that we had no knowledge of other work being done, I'm not going to fault him particularly (although, as I stated, we should have awaited Jim's feedback as was requested). Now that we know that others are actively working on the build system, we will naturally await their opinions for non-trivial changes.

 -Hal

> 
> 
> Really?
> 
> 
> Andrey
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory