[Openmp-dev] [PATCH] [Revisedx2] Initial cmake support

["C. Bergström"]

On 06/ 2/14 04:50 PM, Cownie, James H wrote:
> Sorry, I am going to revert this check in.
>
> * You are moving too fast; all of this has been done since noon on Friday here in the UK,
>    and I was out on Friday afternoon and do not work at weekends. I have therefore had no chance to
>    look at it before it was checked in. (And I'm supposed to be a key reviewer and architect here...)
>
> * A change like this (which provides a whole new build system) requires more than one review.
>
> * Since everyone complained so much, we have been working on a CMAKE based build system here at Intel
>    that we hope to push this week, which *does* support Windows, icc, gcc, clang etc
>
> So, at the point when I commit that, I'm going to remove these changes.
>
> By all means give me grief and complain about your wasted time. There's not a lot I can do about it, though.
At the point (1 week?) Intel or someone else proposes a new build system 
which has been reviewed and accepted. It makes total sense to remove 
what's there already. Adding a new build system doesn't make the sky 
fall. Please don't be upset because you didn't have a chance to review 
the changes. It's not rocket science and has been tested by more than 
one person with expert knowledge.

Wasted effort or not - I'm happy someone cared enough to take this 
matter on and do it.