<html><body><p><font size="2">Hi Hal,</font><br><br><font size="2">Thanks for spotting this. -j was set to 1 initially because back then libomptarget was NOT thread-safe, so we had to serialize the tests. This is no longer the case, so we can change the configuration to use all available resources of the system. I will submit a patch.</font><br><br><font size="2">George</font><br><br><img width="16" height="16" src="cid:1__=0ABB0B92DFCD39D28f9e8a93df938690918c0AB@" border="0" alt="Inactive hide details for Hal Finkel ---13/04/2017 12:35:56---Hi George, On 01/25/2017 03:27 PM, George Rokos via Openmp-commit"><font size="2" color="#424282">Hal Finkel ---13/04/2017 12:35:56---Hi George, On 01/25/2017 03:27 PM, George Rokos via Openmp-commits wrote:</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Hal Finkel <hfinkel@anl.gov></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Georgios Rokos/Watson/IBM@IBMUS, <openmp-commits@lists.llvm.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">13/04/2017 12:35</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [Openmp-commits] [openmp] r293094 - [OpenMP] Initial implementation of OpenMP offloading library - libomptarget.</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt><font size="2">Hi George,<br><br><br><br>On 01/25/2017 03:27 PM, George Rokos via Openmp-commits wrote:<br>> Author: grokos<br>> Date: Wed Jan 25 15:27:24 2017<br>> New Revision: 293094<br>><br>> URL: </font></tt><tt><font size="2"><a href="http://llvm.org/viewvc/llvm-project?rev=293094&view=rev">http://llvm.org/viewvc/llvm-project?rev=293094&view=rev</a></font></tt><tt><font size="2"><br>> Log:<br>> [OpenMP] Initial implementation of OpenMP offloading library - libomptarget.<br>><br>> This is the patch upstreaming the device-agnostic part of libomptarget.<br>><br>> Differential Revision: </font></tt><tt><font size="2"><a href="https://reviews.llvm.org/D14031">https://reviews.llvm.org/D14031</a></font></tt><tt><font size="2"><br>><br>><br>> ...<br>> + # Use add_lit_testsuite() from LLVM CMake. This also depends on OpenMP<br>> + # implementation because it uses omp.h.<br>> + add_lit_testsuite(check-libomptarget<br>> + "Running libomptarget tests"<br>> + ${CMAKE_CURRENT_BINARY_DIR}<br>> + ARGS "-j 1"<br><br>Adding -j 1 may be okay for the stand-alone testing configuration, but <br>we can't add it here like this. The argument applies not only to the <br>tests in this subdirectory, but to all regression tests being run. That <br>means that running check-all after a complete build might take 20 <br>minutes instead of 1. Is there a reason we need to be (more) careful <br>about this here than we are for the openmp tests? As a note, we <br>definitely over-subscribe the system for the openmp tests, but they're <br>not performance tests, and the stressing has often proved helpful.<br><br>Thanks again,<br>Hal<br><br>> + DEPENDS omptarget omp<br>> + )<br>> +<br>> ...<br>><br>> _______________________________________________<br>> Openmp-commits mailing list<br>> Openmp-commits@lists.llvm.org<br>> </font></tt><tt><font size="2"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits</a></font></tt><tt><font size="2"><br><br>-- <br>Hal Finkel<br>Lead, Compiler Technology and Programming Languages<br>Leadership Computing Facility<br>Argonne National Laboratory<br><br></font></tt><br><br><BR>
</body></html>