<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 04/13/2017 12:26 PM, Georgios Rokos
wrote:<br>
</div>
<blockquote
cite="mid:OFE85ABD18.379E3253-ON85258101.005EBF42-85258101.005FC8B3@notes.na.collabserv.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p><font size="2">Hi Hal,</font><br>
<br>
<font size="2">Thanks for spotting this.</font></p>
</blockquote>
<br>
No problem. I finally got around to trying to figure out why my
nightly builds were taking 30 minutes longer than last year. :-)<br>
<br>
<blockquote
cite="mid:OFE85ABD18.379E3253-ON85258101.005EBF42-85258101.005FC8B3@notes.na.collabserv.com"
type="cite">
<p><font size="2"> -j was set to 1 initially because back then
libomptarget was NOT thread-safe, so we had to serialize the
tests. This is no longer the case, so we can change the
configuration to use all available resources of the system. I
will submit a patch.</font><br>
</p>
</blockquote>
<br>
Great, thanks!<br>
<br>
-Hal<br>
<br>
<blockquote
cite="mid:OFE85ABD18.379E3253-ON85258101.005EBF42-85258101.005FC8B3@notes.na.collabserv.com"
type="cite">
<p><br>
<font size="2">George</font><br>
<br>
<img src="cid:part1.76C84146.878F1C16@anl.gov" alt="Inactive
hide details for Hal Finkel ---13/04/2017 12:35:56---Hi
George, On 01/25/2017 03:27 PM, George Rokos via
Openmp-commit" border="0" height="16" width="16"><font
color="#424282" size="2">Hal Finkel ---13/04/2017
12:35:56---Hi George, On 01/25/2017 03:27 PM, George Rokos via
Openmp-commits wrote:</font><br>
<br>
<font color="#5F5F5F" size="2">From: </font><font size="2">Hal
Finkel <a class="moz-txt-link-rfc2396E" href="mailto:hfinkel@anl.gov"><hfinkel@anl.gov></a></font><br>
<font color="#5F5F5F" size="2">To: </font><font size="2">Georgios
Rokos/Watson/IBM@IBMUS, <a class="moz-txt-link-rfc2396E" href="mailto:openmp-commits@lists.llvm.org"><openmp-commits@lists.llvm.org></a></font><br>
<font color="#5F5F5F" size="2">Date: </font><font size="2">13/04/2017
12:35</font><br>
<font color="#5F5F5F" size="2">Subject: </font><font size="2">Re:
[Openmp-commits] [openmp] r293094 - [OpenMP] Initial
implementation of OpenMP offloading library - libomptarget.</font><br>
</p>
<hr style="color:#8091A5; " align="left" noshade="noshade"
size="2" width="100%"><br>
<br>
<br>
<tt><font size="2">Hi George,<br>
<br>
<br>
<br>
On 01/25/2017 03:27 PM, George Rokos via Openmp-commits wrote:<br>
> Author: grokos<br>
> Date: Wed Jan 25 15:27:24 2017<br>
> New Revision: 293094<br>
><br>
> URL: </font></tt><tt><font size="2"><a
moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=293094&view=rev">http://llvm.org/viewvc/llvm-project?rev=293094&view=rev</a></font></tt><tt><font
size="2"><br>
> Log:<br>
> [OpenMP] Initial implementation of OpenMP offloading
library - libomptarget.<br>
><br>
> This is the patch upstreaming the device-agnostic part of
libomptarget.<br>
><br>
> Differential Revision: </font></tt><tt><font size="2"><a
moz-do-not-send="true"
href="https://reviews.llvm.org/D14031">https://reviews.llvm.org/D14031</a></font></tt><tt><font
size="2"><br>
><br>
><br>
> ...<br>
> + # Use add_lit_testsuite() from LLVM CMake. This also
depends on OpenMP<br>
> + # implementation because it uses omp.h.<br>
> + add_lit_testsuite(check-libomptarget<br>
> + "Running libomptarget tests"<br>
> + ${CMAKE_CURRENT_BINARY_DIR}<br>
> + ARGS "-j 1"<br>
<br>
Adding -j 1 may be okay for the stand-alone testing
configuration, but <br>
we can't add it here like this. The argument applies not only
to the <br>
tests in this subdirectory, but to all regression tests being
run. That <br>
means that running check-all after a complete build might take
20 <br>
minutes instead of 1. Is there a reason we need to be (more)
careful <br>
about this here than we are for the openmp tests? As a note,
we <br>
definitely over-subscribe the system for the openmp tests, but
they're <br>
not performance tests, and the stressing has often proved
helpful.<br>
<br>
Thanks again,<br>
Hal<br>
<br>
> + DEPENDS omptarget omp<br>
> + )<br>
> +<br>
> ...<br>
><br>
> _______________________________________________<br>
> Openmp-commits mailing list<br>
> <a class="moz-txt-link-abbreviated" href="mailto:Openmp-commits@lists.llvm.org">Openmp-commits@lists.llvm.org</a><br>
> </font></tt><tt><font size="2"><a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits</a></font></tt><tt><font
size="2"><br>
<br>
-- <br>
Hal Finkel<br>
Lead, Compiler Technology and Programming Languages<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
<br>
</font></tt><br>
<br>
<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>