[Openmp-commits] [openmp] [libomptarget] Support BE ELF files in plugins-nextgen (PR #83976)

[Joseph Huber via Openmp-commits]

================
@@ -283,3 +295,44 @@ Expected<const void *> utils::elf::getSymbolAddress(
 
   return ELFFile.base() + Offset;
 }
+
+template <class ELFT>
+static Expected<std::optional<StringRef>>
+findSymbolInImageImpl(const object::ELFObjectFile<ELFT> &ELFObj,
+                      StringRef Name) {
+  // Search for the symbol by name.
----------------
jhuber6 wrote:

Nit, a lot of these comments are just restating what is generally observable from the code. I.e. `getSymbol(ELFObj, Name)` implies we're looking up a symbol by name.

https://github.com/llvm/llvm-project/pull/83976