[Openmp-commits] [openmp] [OpenMP] Enable automatic unified shared memory on MI300A. (PR #77512)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 16 14:23:42 PST 2024


================
@@ -1940,6 +1964,19 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
     if (auto Err = AMDGPUSignalManager.init(OMPX_InitialNumSignals))
       return Err;
 
+    // Detect if XNACK is enabled
+    auto TargeTripleAndFeaturesOrError =
+        utils::getTargetTripleAndFeatures(Agent);
+    if (!TargeTripleAndFeaturesOrError)
+      return TargeTripleAndFeaturesOrError.takeError();
+    StringRef TargeTripleAndFeatures(*TargeTripleAndFeaturesOrError);
+    if (TargeTripleAndFeatures.contains("xnack+"))
----------------
jhuber6 wrote:

Nit, it's just do `->contains` and save the extra var.

https://github.com/llvm/llvm-project/pull/77512


More information about the Openmp-commits mailing list