[Openmp-commits] [openmp] [Libomptarget] Minimize use of 'REPORT' in the plugin interface (PR #78182)

Jan Patrick Lehr via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 16 08:19:28 PST 2024


jplehr wrote:

> > A runtime rolling over and dying when something goes wrong is generally unacceptable, but currently most of these will still die at the plugin boundary.
> 
> I agree. I think generally in debug build we might want to abort immediately to make it easy to pinpoint where things start to go south. In release build we can just report the error and return failure, etc., and eventually `libomptarget` will crash due to error.

With a debug build, do you mean `LIBOMPTARGET_DEBUG` or CMake Debug build?
If we want to go that route, can we potentially not tie the ability to debug-print stuff and die in case of error? I think it would be good to be able to have a debug log w/o enabling dying immediately. Like have `LIBOMPTARGET_DEBUG_ABORT_EARLY` or something.

https://github.com/llvm/llvm-project/pull/78182


More information about the Openmp-commits mailing list