[Openmp-commits] [openmp] [OpenMP] Enable automatic unified shared memory on MI300A. (PR #77512)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 16 07:36:49 PST 2024


================
@@ -2728,6 +2780,34 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
     return Err;
   }
 
+  /// Detect if current architecture is an APU.
+  Error checkIfAPU() {
----------------
jhuber6 wrote:

I'm just confused, because the name suggests that the full profile implies we have USM, which is what's necessary for this behavior. The ROCR code in question uses the same logic to set a variable called `isAPU` which suggests the same logic t his `checkIfAPU` is trying to accomplish. I guess the problem is that this is more general than what we're going for here and merely want it for this single MI300 architecture?

https://github.com/llvm/llvm-project/pull/77512


More information about the Openmp-commits mailing list