[Openmp-commits] [openmp] [openmp] Fix warnings when building on Windows with latest MSVC or Clang ToT (PR #77853)

via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 16 07:13:52 PST 2024


================
@@ -127,8 +127,9 @@ const char *__kmp_hw_get_catalog_string(kmp_hw_t type, bool plural) {
     return ((plural) ? KMP_I18N_STR(Threads) : KMP_I18N_STR(Thread));
   case KMP_HW_PROC_GROUP:
     return ((plural) ? KMP_I18N_STR(ProcGroups) : KMP_I18N_STR(ProcGroup));
+  default:
----------------
zmodem wrote:

In this and the other instances, is it just one or two cases missing for the switch to be covered, or what's the situation?

In general it's nicer to cover all cases explicitly, so that clang will warn if a new enumerator gets added later. But if they're too many, I suppose default is good too.

https://github.com/llvm/llvm-project/pull/77853


More information about the Openmp-commits mailing list