[Openmp-commits] [openmp] [Libomptarget] Minimize use of 'REPORT' in the plugin interface (PR #78182)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Mon Jan 15 12:00:53 PST 2024


jhuber6 wrote:

> The early abortion can help to locate the error much easier because we don't have to wait for the handling of offloading failure that might happen much later than when and where it happens.

A runtime rolling over and dying when something goes wrong is generally unacceptable, but currently most of these will still die at the plugin boundary. The one concession is the allocation bits, I could probably keep those messages around with a debugging message. I think in the future we should make these allocation routines return an error as well so it forces the user to handle the `nullptr` case explicitly. 

https://github.com/llvm/llvm-project/pull/78182


More information about the Openmp-commits mailing list