[Openmp-commits] [openmp] [Libomptarget] Move target table handling out of the plugins (PR #77150)

[Joseph Huber via Openmp-commits]

jhuber6 wrote:

> Couldn't we provide an API for the plugin to pass a reference to a GlobalHandler back to do most of this?

This is possible, but the existence of the C API between `libomptarget` and the plugins makes it annoying. I like having functions that abstract over the operations the underlying runtime do. But, we could go that route in a follow-up and merge `__tgt_rtl_data_(submit|retrieve)` and these into a single interface.

> > This removes support for the dumpGlobals() routines
> > which are used for record & replay.
> 
> That's a problem.
>

Should hopefully work, but I'll need to check it further. I simply made the recording facilities append globals.

> > There's no tests that test this however.
> 
> That's a different problem.

Why were tests not included in https://reviews.llvm.org/D138931 when this was first added?

https://github.com/llvm/llvm-project/pull/77150