[Openmp-commits] [openmp] [OpenMP][Offloading][AMDGPU] Exclude `nogpulib` in `lit.cfg` (PR #76702)

[Kareem Ergawy via Openmp-commits]

ergawy wrote:

> What failures is this causing?

These are the failing tests:
```
Failed Tests (11):
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/basic-target-region-1D-array-section.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/basic-target-region-3D-array-section.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/basic-target-region-3D-array.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/basic_target_region.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/constant-arr-index.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/declare-target-array-in-target-region.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/double-target-call-with-declare-target.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/target-region-implicit-array.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/target_map_common_block.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/target_map_common_block2.f90
  libomptarget :: amdgcn-amd-amdhsa :: offloading/fortran/target_update.f90
```

And they fail with the following error:
```
# .---command stderr------------
# | flang-new: error: unknown argument '-nogpulib'; did you mean '-Xclang -nogpulib'?
# `-----------------------------
```

> This was not an oversight, ...

Apologies for assuming that without much background. From the name of the flag, I (possibly incorrectly) assumed that if we pass it to flang, then the device RT lib(s) won't be linked into the final binary which, in turn, will prevent offloading from taking place. That's why, I thought that excluding this flag for the `amdgcn-amd-amdhsa` target makes sense.

The flag is not supported by flang (as evident from the error message), and there is a PR (#71045) to add it. However, I think adding it might not be the solution for these particular offloading tests.

Please let me know if I missed something.

https://github.com/llvm/llvm-project/pull/76702