[Openmp-commits] [openmp] [OpenMP] Implements __kmp_is_address_mapped for Solaris/Illumos. (PR #82930)

[David CARLIER via Openmp-commits]

devnexen wrote:

> > I tried on an Illumos based distro (openinidiana), note that illumos supports [`pthread_attr_get_np`](https://illumos.org/man/3C/pthread_attr_get_np) but not solaris.
> 
> So you're adding a third variant when a simple conditional to distinguish between Solaris and Illumos would do? And how will you handle some case where there's no common ground between the two?
> 
> The Illumos community finally needs to deal with Issue #53919: @MaskRay asked me to file it two years ago when running into Illumos/Solaris differences wrt. `dlpi_tls_modid` in `struct dl_phdr_info` and stop worrying about Illumos until they got this Issue resolved. Two years later and not a thing has happened...

Unfortunately, it s the reality of OSS ; for now I m using an old api present in both proprietary and opensolaris descendants :) I realise now that even [sanitizers use it too](https://github.com/llvm/llvm-project/blob/56ad6d19397c4286fa412f5070fd1a563b6c43e4/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp#L146).

https://github.com/llvm/llvm-project/pull/82930