[Openmp-commits] [openmp] [Libomptarget] Remove global ctor and use reference counting (PR #80499)

via Openmp-commits openmp-commits at lists.llvm.org
Wed Feb 21 08:18:19 PST 2024


https://github.com/dhruvachak approved this pull request.

LGTM. The init/deinit code should not be performance critical, so i think having a mutex is ok. Now that RefCount is not atomic, there should not be any confusion about any future usage, it would have to be protected by the mutex.

In addition, I did some testing with OMPT and this patch since OMPT has some ordering constraints. That appeared ok too.

https://github.com/llvm/llvm-project/pull/80499


More information about the Openmp-commits mailing list