[Openmp-commits] [openmp] [OpenMP] HSA_ENABLE_SDMA visible in libomptarget tests (PR #80860)

Jan Patrick Lehr via Openmp-commits openmp-commits at lists.llvm.org
Tue Feb 6 08:01:53 PST 2024


https://github.com/jplehr created https://github.com/llvm/llvm-project/pull/80860

Enable the environment variable inside the test environment. This allows to disable SDMA engine transfers as a potential mitigation of flaky OpenMP offloading tests on AMDGPU.

Motivated by the open ticket https://github.com/ROCm/ROCm/issues/2616 about a missed synchronization signal.

>From 184ec72023455c08f3f3187df6e244ffec54735d Mon Sep 17 00:00:00 2001
From: JP Lehr <JanPatrick.Lehr at amd.com>
Date: Tue, 6 Feb 2024 09:42:59 -0600
Subject: [PATCH] [OpenMP] HSA_ENABLE_SDMA visible in libomptarget tests

Enable the environment variable inside the test environment. This allows
to disable SDMA engine transfers as a potential mitigation of flaky
OpenMP offloading tests on AMDGPU.

Motivated by the open ticket https://github.com/ROCm/ROCm/issues/2616
about a missed synchronization signal.
---
 openmp/libomptarget/test/lit.cfg | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/openmp/libomptarget/test/lit.cfg b/openmp/libomptarget/test/lit.cfg
index d912b622c05ba1..fc1d436e51b7bd 100644
--- a/openmp/libomptarget/test/lit.cfg
+++ b/openmp/libomptarget/test/lit.cfg
@@ -31,6 +31,9 @@ if 'LIBOMPTARGET_LOCK_MAPPED_HOST_BUFFERS' in os.environ:
 if 'OMP_TARGET_OFFLOAD' in os.environ:
     config.environment['OMP_TARGET_OFFLOAD'] = os.environ['OMP_TARGET_OFFLOAD']
 
+if 'HSA_ENABLE_SDMA' in os.environ:
+    config.environment['HSA_ENABLE_SDMA'] = os.environ['HSA_ENABLE_SDMA']
+
 # set default environment variables for test
 if 'CHECK_OPENMP_ENV' in os.environ:
     test_env = os.environ['CHECK_OPENMP_ENV'].split()



More information about the Openmp-commits mailing list