[Openmp-commits] [openmp] [Libomptarget] Remove requires information from plugin (PR #80345)

[Joseph Huber via Openmp-commits]

jhuber6 wrote:

> I need to look more carefully at the patch, but automatic zero copy decision is taken in the amdgpu plugin if the program did not have 'requires unified_shared_memory'. If you remove that information from the plugin how can it know that automatic zero-copy needs to be turned on? At the same time, runtime decision on zero-copy for amdgpu's is based on the machine being an APU, and that is a vendor specific information that cannot be moved to libomptarget.

This was the only use upstream. I see there are some more uses downstream that I wasn't aware of. Obviously the APU stuff is device dependent which is why it stayed where it is.

The use downstream seems to be some kind of checks for prepopulating some table? I don't fully understand that. It seems you and @ThorBl were involved in those changes, so maybe you know what the requirements are there. Either way, I don't think that we should use the same "requires" flags.

https://github.com/llvm/llvm-project/pull/80345