[Openmp-commits] [openmp] 75e6480 - [Libomptarget] Disable AMDGPU complex math test after recent patch

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Wed Oct 4 13:25:00 PDT 2023


Author: Joseph Huber
Date: 2023-10-04T15:24:43-05:00
New Revision: 75e648031c39bb602b02d83021eda59fd8fc2259

URL: https://github.com/llvm/llvm-project/commit/75e648031c39bb602b02d83021eda59fd8fc2259
DIFF: https://github.com/llvm/llvm-project/commit/75e648031c39bb602b02d83021eda59fd8fc2259.diff

LOG: [Libomptarget] Disable AMDGPU complex math test after recent patch

Summary:
The recent patch added `-nogpulib` to make these tests only pick up what
was intentionally put into them. This had the effect of removing the
dependency on the ROCm device libs which are needed for math. This test
disables the complex math test, which is the only one that needed it,
for the time being. In the future we will implement these and provide it
via the GPU `libm` and pass it in the same way as the GPU `libc`.

Added: 
    

Modified: 
    openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp b/openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp
index b06d605d29f90cf..44f87ad732bfbf7 100644
--- a/openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp
+++ b/openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp
@@ -3,6 +3,10 @@
 // RUN: %libomptarget-compilexx-generic -O3 -ffast-math && \
 // RUN:   %libomptarget-run-generic
 
+// FIXME: This fails to link due to missing math symbols. We should provide the
+//        needed math functions in the GPU `libm` and require the GPU C library.
+// UNSUPPORTED: amdgcn-amd-amdhsa
+
 #include <cassert>
 #include <complex>
 #include <iostream>


        


More information about the Openmp-commits mailing list