[Openmp-commits] [PATCH] D152462: [OpenMP] Fix --libomptarget-nvptx-bc-path in tests

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.
Herald added a subscriber: wangpc.

This is moderately interesting. I think the bc-path flag lets one specify either a specific library or a directory to look for a library in, and I'm guessing we're using the directory form so we guess the right lib based on architecture name. Something like

`llvm/runtimes/runtimes-bins/openmp/libomptarget/DeviceRTL/packaged_libomptarget-nvptx-sm_75.bc`

but I can't think of a reason why this should be nvptx specific, and I think we introduced this because otherwise the test suite runs with whatever bitcode file it found on disk with the right sort of name as opposed to the bitcode file we just built and would like to test.

https://reviews.llvm.org/D142491 (or probably a fix following it) dropped the line specifying the bitcode library to use in favour of a static archive chosen by clang.

I think that's pretty suspect - maybe something forces the clang running the tests to pick the right static archive, but I haven't found it. Seems likely it's running using the same static libary that clang would find outside of the test harness, which is not especially likely to be the one just built.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152462/new/

https://reviews.llvm.org/D152462