[Openmp-commits] [openmp] [Libomptarget] Handle dynamic stack sizes for AMD COV5 (PR #72606)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Mon Nov 20 06:39:31 PST 2023


================
@@ -658,7 +664,8 @@ struct AMDGPUQueueTy {
     Packet->grid_size_x = NumBlocks * NumThreads;
     Packet->grid_size_y = 1;
     Packet->grid_size_z = 1;
-    Packet->private_segment_size = Kernel.getPrivateSize();
+    Packet->private_segment_size =
+        Kernel.usesDynamicStack() ? Kernel.getPrivateSize() : StackSize;
----------------
jhuber6 wrote:

Ack, you're right it's backwards. I think it's correct in the `libc` version of this patch, but for some reason I deleted the `!` and didn't reverse it.

https://github.com/llvm/llvm-project/pull/72606


More information about the Openmp-commits mailing list