[Openmp-commits] [openmp] [llvm] [clang] [OpenMP] Rework handling of global ctor/dtors in OpenMP (PR #71739)

via Openmp-commits openmp-commits at lists.llvm.org
Fri Nov 10 06:38:13 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 2984156fd34a6969c7461b228d90b72711e3797c 0f184906bc8ceeaefe724847d4256c0c285bb3e2 -- openmp/libomptarget/test/libc/global_ctor_dtor.cpp clang/include/clang/Basic/LangOptions.h clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CodeGenFunction.h clang/lib/CodeGen/CodeGenModule.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Headers/amdgcn_openmp_device_math_constexpr.cpp clang/test/OpenMP/amdgcn_target_global_constructor.cpp clang/test/OpenMP/declare_target_codegen.cpp clang/test/OpenMP/nvptx_declare_target_var_ctor_dtor_codegen.cpp llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp openmp/libomptarget/src/rtl.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/Basic/LangOptions.h b/clang/include/clang/Basic/LangOptions.h
index b7edda6f97d7..ae99357eeea7 100644
--- a/clang/include/clang/Basic/LangOptions.h
+++ b/clang/include/clang/Basic/LangOptions.h
@@ -598,9 +598,7 @@ public:
   }
 
   /// Returns true if the language supports calling the 'atexit' function.
-  bool hasAtExit() const {
-    return !(OpenMP && OpenMPIsTargetDevice);
-  }
+  bool hasAtExit() const { return !(OpenMP && OpenMPIsTargetDevice); }
 
   /// Returns true if implicit int is part of the language requirements.
   bool isImplicitIntRequired() const { return !CPlusPlus && !C99; }

``````````

</details>


https://github.com/llvm/llvm-project/pull/71739


More information about the Openmp-commits mailing list