[Openmp-commits] [openmp] [openmp][testing] disable check targets if not building with clang (PR #71866)

Maksim Levental via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 9 18:18:50 PST 2023


makslevental wrote:

> libomptarget

the problem is the tests aren't factored in such a way that that's possible right? When you don't have a clang target available, the actual CMake error comes from the `add_lit_testsuite` depending on `clang` [here](https://github.com/llvm/llvm-project/blob/main/openmp/cmake/OpenMPTesting.cmake#L221-L228):

```
    if (ARG_EXCLUDE_FROM_CHECK_ALL)
      add_lit_testsuite(${target}
        ${comment}
        ${ARG_UNPARSED_ARGUMENTS}
        EXCLUDE_FROM_CHECK_ALL
        DEPENDS clang FileCheck not ${ARG_DEPENDS}
        ARGS ${ARG_ARGS}
      )
    else()
      add_lit_testsuite(${target}
        ${comment}
        ${ARG_UNPARSED_ARGUMENTS}
        DEPENDS clang FileCheck not ${ARG_DEPENDS}
        ARGS ${ARG_ARGS}
      )
    endif()
```

So fiddling with `libomptarget` tests won't work.

https://github.com/llvm/llvm-project/pull/71866


More information about the Openmp-commits mailing list