[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added a comment.

Thanks for moving this forward.



================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:386
+#ifdef OMPT_SUPPORT
+  bool expectedStatus = false;
+  if (OmptDevice.compare_exchange_strong(expectedStatus, true))
----------------
Nit: I believe this should start w/ capital letter.


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:448
+#ifdef OMPT_SUPPORT
+  bool expectedStatus = true;
+  if (OmptDevice.compare_exchange_strong(expectedStatus, false))
----------------
captial E


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652