[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:137
+#else
+extern "C" {
+/// Dummy definition when OMPT is disabled
----------------
tianshilei1992 wrote:
> Will it cause some link error if `ompt_libomptarget_connect` is not defined but mentioned in `exports`?
Yes, also with the guarded `target_link_libraries(...)` you suggested -- I just tried it.
If there's another approach or better practice, I'd be very interested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070