[Openmp-commits] [PATCH] D148808: [OpenMP][libomptarget][AMDGPU] Enable optional active HSA wait state

Ye Luo via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed May 3 07:11:17 PDT 2023


ye-luo accepted this revision.
ye-luo added inline comments.
This revision is now accepted and ready to land.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:900
+  /// Timeout hint for HSA actively waiting for signal value to change
+  const uint64_t StreamBusyWaitMicroseconds;
+
----------------
Could you move this right below line 891 mutex? Prefer not to have variables stuck between functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148808/new/

https://reviews.llvm.org/D148808



More information about the Openmp-commits mailing list