[Openmp-commits] [PATCH] D149685: [OpenMP] libomptarget: Don't map alignment padding to host

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 2 13:26:15 PDT 2023


jdenny created this revision.
jdenny added reviewers: jdoerfert, jhuber6, grokos, pavelkopyl, tianshilei1992, ye-luo, RaviNarayanaswamy.
jdenny added a project: OpenMP.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
jdenny requested review of this revision.
Herald added subscribers: jplehr, sstefan1.

In the case of partially mapped structs, libomptarget sometimes adds
padding to device allocations to ensure they are aligned properly.
However, without this patch, it considers that padding to be mapped to
the host, which can cause array extension errors when other parts of
the struct are separately mapped.  This patch keeps the padding but 
treats it as unmapped.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149685

Files:
  openmp/libomptarget/include/device.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/test/mapping/padding_not_mapped.c
  openmp/libomptarget/test/mapping/power_of_two_alignment.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149685.518841.patch
Type: text/x-patch
Size: 14241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230502/bf24ef82/attachment-0001.bin>


More information about the Openmp-commits mailing list