[Openmp-commits] [PATCH] D149391: [OpenMP] Add missing -L to libomptarget tests

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon May 1 10:27:50 PDT 2023


jdenny added a comment.

In D149391#4303774 <https://reviews.llvm.org/D149391#4303774>, @JonChesterfield wrote:

> Interesting. I wonder what libraries were being picked up before - maybe from the cmake install directory?

Revisiting this today, I think that "before" might mean "before the patch under review".  When Clang invokes ld, it first passes -L from its own command line (in this case specified in the lit config), then -L for system directories, and then -L for the build's lib directory.  That should make it clear why it normally works fine if there's no libomptarget.so in a system directory, and otherwise the Clang command line needs add a -L for the build's lib directory to avoid it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149391/new/

https://reviews.llvm.org/D149391



More information about the Openmp-commits mailing list