[Openmp-commits] [PATCH] D146642: [OpenMP] Implement task record and replay mechanism

Jose Manuel Monsalve Diaz via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Mar 24 17:05:00 PDT 2023


josemonsalve2 added inline comments.


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:1198-1200
+  if (is_taskgraph) {
+    if (__kmp_track_children_task(taskdata)) {
+      if (taskdata->td_taskgroup) {
----------------
It may be better to use and instead of nested if
`if (is_taskgraph && __kmp_track_children_task(taskdata) && taskdata->td_taskgroup)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146642/new/

https://reviews.llvm.org/D146642



More information about the Openmp-commits mailing list