[Openmp-commits] [PATCH] D146849: [OpenMP][libomptarget] Active and blocking HSA wait states

[Ye Luo via Phabricator via Openmp-commits]

ye-luo added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:555
+  /// Microseconds to stay in HSA_WAIT_STATE_ACTIVE before switching to blocking
+  uint64_t MicrosToWait;
+
----------------
const uint64_t MicrosToWait


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1964
+      /* Example use for microseconds to wait */
+      AMDGPUSignalTy Signal(300000);
       if (auto Err = Signal.init())
----------------
Not getting what you mean by "Example use".
Could you document the magic number 300000?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146849/new/

https://reviews.llvm.org/D146849