[Openmp-commits] [openmp] 1c43be0 - [Libomptarget] Update CMake messages if the tests aren't build

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Fri Mar 24 12:27:21 PDT 2023


Author: Joseph Huber
Date: 2023-03-24T14:26:23-05:00
New Revision: 1c43be0276a13ed1ff9d593d2e251a4f7ad69287

URL: https://github.com/llvm/llvm-project/commit/1c43be0276a13ed1ff9d593d2e251a4f7ad69287
DIFF: https://github.com/llvm/llvm-project/commit/1c43be0276a13ed1ff9d593d2e251a4f7ad69287.diff

LOG: [Libomptarget] Update CMake messages if the tests aren't build

Summary:
These messages have been wrong for quite some time. Update them to be
more descriptive of why the tests weren't built.

Added: 
    

Modified: 
    openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
    openmp/libomptarget/plugins/cuda/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt b/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
index 7462b4cf961a8..e8abfb8247936 100644
--- a/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
+++ b/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
@@ -117,7 +117,6 @@ if (LIBOMPTARGET_FOUND_AMDGPU_GPU OR LIBOMPTARGET_FORCE_AMDGPU_TESTS)
   list(APPEND LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.amdgpu")
   set(LIBOMPTARGET_TESTED_PLUGINS "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE)
 else()
-  libomptarget_say("Not generating amdgcn test targets as libhsa is not linkable")
+  libomptarget_say("Not generating AMDGPU tests, no supported devices detected. Use 'LIBOMPTARGET_FORCE_AMDGPU_TESTS' to override.")
   return()
 endif()
-

diff  --git a/openmp/libomptarget/plugins/cuda/CMakeLists.txt b/openmp/libomptarget/plugins/cuda/CMakeLists.txt
index d330291ef3194..c4c460569361c 100644
--- a/openmp/libomptarget/plugins/cuda/CMakeLists.txt
+++ b/openmp/libomptarget/plugins/cuda/CMakeLists.txt
@@ -72,5 +72,5 @@ if (LIBOMPTARGET_FOUND_NVIDIA_GPU OR LIBOMPTARGET_FORCE_NVIDIA_TESTS)
   list(APPEND LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.cuda")
   set(LIBOMPTARGET_TESTED_PLUGINS "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE)
 else()
-  libomptarget_say("Disabling tests using CUDA plugin as cuda may not be available")
+  libomptarget_say("Not generating NVIDIA tests, no supported devices detected. Use 'LIBOMPTARGET_FORCE_NVIDIA_TESTS' to override.")
 endif()


        


More information about the Openmp-commits mailing list