[Openmp-commits] [PATCH] D144419: Improvements to the OpenMP Windows build

Fri Mar 24 09:45:14 PDT 2023

mstorsjo added a comment.

In D144419#4219864 <https://reviews.llvm.org/D144419#4219864>, @vadikp-intel wrote:

> Could you describe some more what needs fixing? The Windows build with a MSVC toolset should perhaps use `lib`.

I'm not sure exactly what should be changed to fix it - I did a quick 5 minute look at it but didn't identify what should be fixed. I'd recommend trying to set up such a build as I described and reproduce it:

In D144419#4219290 <https://reviews.llvm.org/D144419#4219290>, @mstorsjo wrote:

> To reproduce, make a build directory as a subdirectory to `llvm-project/llvm`, and configure it with `cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;openmp"`. When I try to build with `ninja`, I get the following error:
>
>   ninja: error: 'projects/openmp/runtime/src/libomp.dll.lib', needed by 'lib/libomp.lib', missing and no known rule to make it

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144419/new/

https://reviews.llvm.org/D144419