[Openmp-commits] [PATCH] D123446: [OpenMP] Remove shadow pointer map and introduce consistent locking

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 21 17:24:34 PDT 2023


jdoerfert updated this revision to Diff 507188.
jdoerfert retitled this revision from "[OpenMP][FIX] Remove shadow pointer map and introduce consistent locking" to "[OpenMP] Remove shadow pointer map and introduce consistent locking".
jdoerfert edited the summary of this revision.
jdoerfert added a comment.
Herald added subscribers: jplehr, sunshaoce.

Rebase, addressed comments, incorporated most parts of https://reviews.llvm.org/D123443.
The mapping stress tests slows down a little but running all AMD GPU tests is as fast as before.
Consistent locking of the entries should be worth it, and the stress test is unlikely anyway.
The set vs unordered set situation is resolved with a SmallSet of size 2, unlikely we attach more pointers into an object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123446/new/

https://reviews.llvm.org/D123446

Files:
  openmp/libomptarget/include/device.h
  openmp/libomptarget/src/api.cpp
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/omptarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123446.507188.patch
Type: text/x-patch
Size: 61164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230322/9b742ab8/attachment-0001.bin>


More information about the Openmp-commits mailing list