[Openmp-commits] [PATCH] D144975: [OpenMP][libomptarget][NFC] Add documentation regarding NextGen plugins

Thu Mar 2 01:04:16 PST 2023

kevinsala added a comment.

In D144975#4161931 <https://reviews.llvm.org/D144975#4161931>, @jhuber6 wrote:

> Should we bother calling them nextgen considering that they will be the only gen in two weeks?

You're right. I'll update it be consistent with D142820 <https://reviews.llvm.org/D142820>.

================
Comment at: openmp/docs/design/Runtimes.rst:1244
+streams. More HSA signals will be created dynamically throughout the execution
+if needed. The default value is ``64``.
+
----------------
jdoerfert wrote:
> Is this separate from the other SIGNALS env var on purpose? We can discuss this in our meeting.
Which SIGNALS envars are you referring to?

There are the other two `LIBOMPTARGET_NUM_INITIAL_STREAMS` and `LIBOMPTARGET_NUM_INITIAL_EVENTS` envars. But these two are different since these two apply to all plugins and `LIBOMPTARGET_AMDGPU_NUM_INITIAL_HSA_SIGNALS` only applies to AMDGPU.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144975/new/

https://reviews.llvm.org/D144975