[Openmp-commits] [PATCH] D149685: [OpenMP] libomptarget: Don't map alignment padding to host

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny updated this revision to Diff 529421.
jdenny edited the summary of this revision.
jdenny added a comment.

In D149685#4332051 <https://reviews.llvm.org/D149685#4332051>, @grokos wrote:

> If there is a valid scenario that doesn't work without this patch then:

After further thought, I believe there are several such scenarios.  For a struct member that only maps to device padding and thus shouldn't be considered present, `omp target update` should have no effect, `omp_target_is_present` should return false, and `present` modifiers should produce runtime errors.  Did I miss anything in the spec that makes these scenarios invalid?

I updated the test and patch summary for these scenarios, and I rebased.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149685/new/

https://reviews.llvm.org/D149685

Files:
  openmp/libomptarget/include/device.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/test/mapping/padding_not_mapped.c
  openmp/libomptarget/test/mapping/power_of_two_alignment.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149685.529421.patch
Type: text/x-patch
Size: 13970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230607/44a17394/attachment.bin>