[Openmp-commits] [PATCH] D125717: [InstCombine] Optimize and of icmps with power-of-2 and contiguous masks

Noah Goldstein via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jun 1 21:21:56 PDT 2023


goldstein.w.n added a comment.

In D125717#4389718 <https://reviews.llvm.org/D125717#4389718>, @jmciver wrote:

> @goldstein.w.n thanks for the reply.
>
> I'll wait until Monday and then proceed to land the patch.
>
> Is it customary to get approval for preceding NFC patches? If yes, can you please take a look at D143044 <https://reviews.llvm.org/D143044>?

No (ish). If you have push access I think its generally fine to push them with the implementation unless someone posts feedback on it.

> Thanks,
> John




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125717/new/

https://reviews.llvm.org/D125717



More information about the Openmp-commits mailing list