[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

Jan-Patrick Lehr via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 25 05:06:15 PDT 2023


jplehr accepted this revision.
jplehr added a comment.

LGTM, assuming build works



================
Comment at: openmp/libomptarget/src/omptarget.cpp:1684
+    int32_t NumTeams = KernelArgs.NumTeams[0];
+    // No need to guard this with OMPT_IF_BUILT
+    InterfaceRAII TargetSubmitRAII(
----------------
nit: Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367



More information about the Openmp-commits mailing list