[Openmp-commits] [PATCH] D155629: [OpenMP][libomptarget] Retrieve multiple resources from resource managers

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 18 15:26:18 PDT 2023


jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1147
     AMDGPUSignalTy *OutputSignals[2] = {nullptr};
-    if (auto Err = SignalManager.getResource(OutputSignals[0]))
-      return Err;
-    if (auto Err = SignalManager.getResource(OutputSignals[1]))
+    if (auto Err = SignalManager.getResources(2, OutputSignals))
       return Err;
----------------
tianshilei1992 wrote:
> 
Should be `/*Num=*/` since `clang-format` understands it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155629/new/

https://reviews.llvm.org/D155629



More information about the Openmp-commits mailing list