[Openmp-commits] [openmp] e526a7f - [Libomptarget][NFC] Clean up warnings and format

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 7 16:59:36 PDT 2023


Author: Joseph Huber
Date: 2023-07-07T18:59:26-05:00
New Revision: e526a7fc15da1d950a3d9fc74ccc2947c28403bc

URL: https://github.com/llvm/llvm-project/commit/e526a7fc15da1d950a3d9fc74ccc2947c28403bc
DIFF: https://github.com/llvm/llvm-project/commit/e526a7fc15da1d950a3d9fc74ccc2947c28403bc.diff

LOG: [Libomptarget][NFC] Clean up warnings and format

Added: 
    

Modified: 
    openmp/libomptarget/plugins-nextgen/common/MemoryManager/MemoryManager.h
    openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
    openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.h

Removed: 
    


################################################################################
diff  --git a/openmp/libomptarget/plugins-nextgen/common/MemoryManager/MemoryManager.h b/openmp/libomptarget/plugins-nextgen/common/MemoryManager/MemoryManager.h
index 8e97fe5c3a5c46..37ef80a1af3ae2 100644
--- a/openmp/libomptarget/plugins-nextgen/common/MemoryManager/MemoryManager.h
+++ b/openmp/libomptarget/plugins-nextgen/common/MemoryManager/MemoryManager.h
@@ -22,7 +22,6 @@
 #include <vector>
 
 #include "Debug.h"
-#include "omptargetplugin.h"
 
 /// Base class of per-device allocator.
 class DeviceAllocatorTy {

diff  --git a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
index ab5ce8cff607f2..f902d4ec70da6a 100644
--- a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
+++ b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
@@ -239,8 +239,8 @@ class DeviceImageTy {
 struct GenericKernelTy {
   /// Construct a kernel with a name and a execution mode.
   GenericKernelTy(const char *Name, OMPTgtExecModeFlags ExecutionMode)
-      : Name(Name), ExecutionMode(ExecutionMode),
-        PreferredNumThreads(0), MaxNumThreads(0) {}
+      : Name(Name), ExecutionMode(ExecutionMode), PreferredNumThreads(0),
+        MaxNumThreads(0) {}
 
   virtual ~GenericKernelTy() {}
 
@@ -255,8 +255,8 @@ struct GenericKernelTy {
                ptr
diff _t *ArgOffsets, KernelArgsTy &KernelArgs,
                AsyncInfoWrapperTy &AsyncInfoWrapper) const;
   virtual Error launchImpl(GenericDeviceTy &GenericDevice, uint32_t NumThreads,
-                           uint64_t NumBlocks,
-                           KernelArgsTy &KernelArgs, void *Args,
+                           uint64_t NumBlocks, KernelArgsTy &KernelArgs,
+                           void *Args,
                            AsyncInfoWrapperTy &AsyncInfoWrapper) const = 0;
 
   /// Get the kernel name.

diff  --git a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.h b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.h
index c072c01b87cb78..f8ffbc6e2a2d81 100644
--- a/openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.h
+++ b/openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.h
@@ -23,7 +23,7 @@
 namespace llvm::omp::target {
 namespace plugin {
 struct GenericDeviceTy;
-struct GenericGlobalHandlerTy;
+class GenericGlobalHandlerTy;
 class DeviceImageTy;
 } // namespace plugin
 


        


More information about the Openmp-commits mailing list