[Openmp-commits] [PATCH] D154456: [Libomptarget] Correctly implement `getWTime` on AMDGPU

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 4 19:28:06 PDT 2023


tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/test/offloading/wtime.c:25
 
 // CHECK: duration: {{.+[1-9]+}}
----------------
tianshilei1992 wrote:
> Probably a more reliable way is to check the diff between duration and `0.0`. as long as it is greater than epsilon we are good.
The check will fail if the time is 0.01 right? You can potentially just do compile and run since you put an assertion there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154456/new/

https://reviews.llvm.org/D154456



More information about the Openmp-commits mailing list