[Openmp-commits] [PATCH] D154312: [Libomptarget] Begin implementing support for RPC services

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:909
+  /// indicates that an RPC server is expected to be run on this stream.
+  RPCHandleTy *RPCDevice;
+
----------------
Name, also elsewhere.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2853-2854
+  // If this kernel requires an RPC server we attach its pointer to the stream.
+  if (GenericDevice.getRPCHandle())
+    Stream.setRPCDevice(GenericDevice.getRPCHandle());
+
----------------
auto RPCHandle = ...
set(RPCHandle)


================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:258
   virtual Error launchImpl(GenericDeviceTy &GenericDevice, uint32_t NumThreads,
-                           uint64_t NumBlocks,
-                           KernelArgsTy &KernelArgs, void *Args,
+                           uint64_t NumBlocks, KernelArgsTy &KernelArgs,
+                           void *Args,
----------------
jdoerfert wrote:
> jhuber6 wrote:
> > tianshilei1992 wrote:
> > > looks like irrelevant changes
> > People somehow commit changes without clang-formatting and then it ends up here because my editor will auto format. Somewhat annoying because I've clang formatted all of these files at least twice by now. I'll trim it.
> Set your editor to only format the lines you changed. Or clang format and precommit.
recommit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154312/new/

https://reviews.llvm.org/D154312