[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:382
+    if (It == KernelInfoMap.end())
+      return {};
+
----------------
nit.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:494
+  /// Additional Info for the AMD GPU Kernel
+  utils::KernelMetaDataTy KernelInfo;
 };
----------------
I still think this should be an optional. Then it's a direct assignment from the table lookup. The only thing you need to change is an `if` when you print it. I'd go ahead and just emit a secondary line for this extra info anyway. That way the first line is still generic between the plugins and this is more info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521