[Openmp-commits] [PATCH] D144521: [OpenMP][AMDGPU] More detail in AMDGPU kernel launch info

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 23 08:29:30 PST 2023


jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:377
+  utils::KernelMetaDataTy getKernelInfo(StringRef Identifier) const {
+    return KernelInfoMap.at(Identifier);
+  }
----------------
Doesn't this crash if the identifier is not present? Should it be a `std::optional` or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144521/new/

https://reviews.llvm.org/D144521



More information about the Openmp-commits mailing list